search

IEA-Task-43 / digital_wra_data_standard

IEA Task 43: pre-construction energy estimate data standard repository
BSD 3-Clause "New" or "Revised" License
56 stars 15 forks source link

[SCHEMA] `device_vertical_orientation` inconsistent naming, missing the '_id' on the end for an enum #234

Open stephenholleran opened 8 months ago

stephenholleran commented 8 months ago

Describe the bug The device_vertical_orientation name is inconsistent with other emuns such as measurement_station_type_id, logger_oem_id, mast_geometry_id, measurement_units_id, statistic_type_id, sensor_type_id, mounting_type_id and structure_type_id as it is missing the "_id" on the end.

Expected behavior As this is an enum, it is expected to have an "_id" on the end of it's name.

Screenshots image

Additional context This will be a breaking change as it is renaming a property.

Similar issue for plant_type.

kersting commented 8 months ago

@stephenholleran thanks for pointing this. We have also another open issue that will likely result in a break change. I suggest we tackled them together. https://github.com/IEA-Task-43/digital_wra_data_standard/issues/153