search

IEA-Task-43 / digital_wra_data_standard

IEA Task 43: pre-construction energy estimate data standard repository
BSD 3-Clause "New" or "Revised" License
56 stars 15 forks source link

iss #225 add license at the top level #242

Closed stephenholleran closed 6 months ago

stephenholleran commented 7 months ago

This relates to issue #225 where the discussion has taken place.

@AndyClifton @abohara if you are both able to review that would be great? Andy from a user perspective and Amit from a have I captured all the places updates need to be made in the schema?

stephenholleran commented 7 months ago

Hi @abohara,

Thanks for taking a look as I know you are traveling.

I updated our main example file with it. Are you asking for the others to be updated too? That can be done no problem.

On the db update, there isn't any table to capture the very top level info such as the author so therefore no place to capture this license either. I would be inclined to leave that info up to each individual organisation's implementation. If you think we should capture it in the db we can create a separate issue to work on that. But at the moment, there is no place to store the license info in the db.

Thanks,

abohara commented 7 months ago

Thanks for clarifying the db concern and making the changes @stephenholleran . Looks good to me.