Open NikoSimisiroglou opened 1 month ago
Hi @NikoSimisiroglou,
Sounds like it is warranted. No harm adding more units to the enum. Are you able to have a go at it by branching off the current dev branch, making the addition and creating a pull request>
Cheers,
@stephenholleran, @abohara, @NikoSimisiroglou, and @heikowestermann I'd also add (m/s)/mV to the list of units in the digital calibration certificate given that if a logger is configured in mV one would need those units for properly handling calibrations on those units. Any opposition?
I don't mind, however in practice we at least have never used mV (yet) and default to V instead.
@heikowestermann thanks for the quick reply! The problem is that we have seen loggers configured with mV instead of V and we have to make sure that we capture all possible units that could arise as a result of having mV to avoid surprises.
@kersting I completely understand and have no objections
Hi,
I have created a branch off issue #248 branch as I moved the measurement_units
into a definition. That branch first needs to be merged into 'dev' before I can create a pull request for this work.
I have added both 'mV' and '(m/s)/mV' to both the wra data model and the DCC.
Are there any other units we want to add while we are at it?
hi @stephenholleran , thank you for creating the branch. I would include the following units as well deg_C/mV, mbar/mV, hPa/mV, %/mV
Is your feature request related to a problem? Please describe. If a slope=1 and offset=0 is applied to a
logger_measurement_config
this could result inmeasurement_units
ofmV
instead ofV
.mV
is not currently supported in the enum list.An example:
measurement_type
pressure will have a value in the timeseries timestep of 2300 and themeasurement_units
is mV not V.Describe the solution you'd like Add
mV
tomeasurement_units
enum list undermeasurement_units_id
Additional context Something similar was requested among others in #106