Catching up the yaml files

IEAWindTask37 / IEA-15-240-RWT

15MW reference wind turbine repository developed in conjunction with IEA Wind

Apache License 2.0

210 stars 133 forks source link

Catching up the yaml files #200

Closed gbarter closed 5 months ago

gbarter commented 5 months ago

Purpose

Caught a couple of updates that had not been propagated to the yaml files- the rotor diameter based on blade projection length and the update to two of the drivetrain keywords from WindIO (thanks to #199)

Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Testing

[x] I have run existing tests which pass locally with my changes
[ ] I have added new tests or examples that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

gbarter commented 5 months ago

@ptrbortolotti - I will go through the OpenFAST files carefully and check if anything needs to change (hoping not much)

jennirinker commented 5 months ago

So it looks like the only thing that has changed in HAWC2 files is:

The mass of the yaw drive
The location and center of gravity of the nacelle
The hub mass and inertia

You've also changed some (perhaps all?) tests from pytest to unittest -- that's fine. EDIT: Garrett points out later in this convo that the tests now worth with both pytest and unittest. 🔥

I have not reviewed the yaml files or the OpenFAST files, but this looks fine from my side.

I consider this ready to merge. @gbarter I give you the honors. :)

gbarter commented 5 months ago

So it looks like the only thing that has changed in HAWC2 files is:

The mass of the yaw drive

The location and center of gravity of the nacelle

The hub mass and inertia

You've also changed some (perhaps all?) tests from pytest to unittest -- that's fine.

I have not reviewed the yaml files or the OpenFAST files, but this looks fine from my side.

I consider this ready to merge. @gbarter I give you the honors. :)

Thanks for the careful review, Jenni! Just FYI- the tests will work with pytest or unittest now. I will make sure @ptrbortolotti has a chance to take a look and then merge.