search

IEAWindTask37 / windIO

Apache License 2.0
19 stars 11 forks source link

Site bathymetry schema #17

Closed kilojoules closed 5 months ago

kilojoules commented 1 year ago

This schema allows bathymetry to be specified as arrays of x, y, and depth, within the YAML file.

kilojoules commented 10 months ago

@ptrbortolotti Thank you. I have updated the PR according to your feedback.

bayc commented 10 months ago

@kilojoules Is it possible to include some example bathymetry data so that these proposed changes can be tested? You can find in examples/plant/validation.py code that verifies all the current aspects of the plant ontology with the available example data, and it would be good to include additional code for bathymetry.

ptrbortolotti commented 8 months ago

@kilojoules thank you for this! is this PR still up to date? are you hoping to address the last comment from @bayc?

kilojoules commented 8 months ago

We discussed it and I am going to try to use the existing constructor. This PR is not ready yet.

bayc commented 6 months ago

I have updated the PR to use the included constructor for loading bathymetry data. I've set the default yaml loader to be the XrResourceLoader, which supports loading yaml files directly or reading in netCDF files in xarray format.

@kilojoules Please test this out with your wind plant repository and verify that it works.