IEC-61400-15 / eya_def

This repository provides a digital format for exchange of information on wind plant energy yield assessment reporting as defined by IEC 61400-15-2.
BSD 3-Clause "New" or "Revised" License
10 stars 0 forks source link

Update data models based on outcome of schema review sessions #28

Closed jonssonchristian closed 11 months ago

jonssonchristian commented 1 year ago
jonssonchristian commented 1 year ago

Hi @AlinaBurmesterRWE , @stephenholleran and @jonnyboxkite, would one of you be able to review this PR, which comprises the changes discussed during the last few schema review sessions? I appreciate there are quite a lot of changes. Quite a bit of it is just renamings and other refactoring.

jonssonchristian commented 1 year ago

I have pushed some updates to this PR, with a few refinements I realised I wanted to implement after I had first created it. I am now done with it and do not expect to change anything further. It is ready for review.

jonssonchristian commented 1 year ago

I now also implemented the additions and changes we agreed during the schema review session on the 14th of November.

If anyone has time to undertake at least a brief high-level review of this PR, that would be brilliant.

jonssonchristian commented 1 year ago

@Raggey, I had not included you in my original request to review this PR as you were not in the list of contributors then. I sent you a new invite and you seem to have access now. If you have some time to do a high-level review of this PR, that would be brilliant, but no worries at all of course if you do not. I thought I ask in any case as you said you might be able to stay involved. As per my other comments, there are a lot of changes, but a lot of it is just renaming, tidying up and other refactoring.

jonssonchristian commented 11 months ago

Since no one volunteered to review this, I will merge it now without review, to allow development work to progress. As discussed and agreed previously in the EYA DEF group meetings, it is not critical to have code review at this stage, where the schema and python tools are under very active development and have not been released yet. Once we have released a first version, I think we should make code review mandatory on all PRs.