search

IEDB / MRO

The MHC Restriction Ontology
8 stars 6 forks source link

2021-11-24 update #127

Closed hectorguzor closed 2 years ago

hectorguzor commented 2 years ago

adds one new term to molecule:

HLA-DQA1 03:01/DQB1 06:04 protein complex

jamesaoverton commented 2 years ago

@beckyjackson There's a problem with this, and I'd appreciate your help. It's been a while, so I didn't notice these probems when I reviewed.

"HLA-DQA103:01/DQB106:04" was already in index.tsv as MRO:0044068 and already in molecule.tsv. It was not in iedb.tsv until this PR.

Our build tools should have screamed about the duplicate in molecule.tsv.

We also should have enforced sorting on this PR.

Please fix this duplicate, and add checks so it won't happen again.

rvita commented 2 years ago

sorry for the duplication, but I am happy that we now have code to prevent it. the excel file is so large now that highlight duplicates no longer works.

On Tue, Nov 30, 2021 at 11:10 AM James A. Overton @.***> wrote:

@beckyjackson https://github.com/beckyjackson There's a problem with this, and I'd appreciate your help. It's been a while, so I didn't notice these probems when I reviewed.

"HLA-DQA103:01/DQB106:04" was already in index.tsv as MRO:0044068 and already in molecule.tsv. It was not in iedb.tsv until this PR.

Our build tools should have screamed about the duplicate in molecule.tsv.

We also should have enforced sorting on this PR.

Please fix this duplicate, and add checks so it won't happen again.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/IEDB/MRO/pull/127#issuecomment-982935627, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKDY47CCCTBQARP3UT4G33UOUOSTANCNFSM5IXGXAQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Randi Vita, M.D. Lead Ontology and Quality Manager Immune Epitope Database and Analysis Project La Jolla Institute for Allergy & Immunology 9420 Athena Circle La Jolla, Ca 92037 @.*** www.immuneepitope.org 858-752-6912