search

IEEE-AlAzhar / Official-Website

The source code for IEEE Al Azhar's website
MIT License
11 stars 8 forks source link

Side drawer. #17

Open esmail-elmoussel opened 4 years ago

esmail-elmoussel commented 4 years ago

First of all it's nice, i like it ..

I think it's gonna be even more nicer if we make it :

1) Open and close smoothly. 2) Close automatically when switching between light and dark mode. 3) Make it a little bit wider at small screens. 4) There is a console.log when ever it's close.

dvmhmdsd commented 4 years ago

I think it's better to be opened while switching between light and dark modes.

esmail-elmoussel commented 4 years ago

Let's make a vote then xD

AbudZohair commented 4 years ago

I think it's better to be opened; maybe the user is trying to see what is this button does or how the dark theme looks, and the user didn't like it.

But when it comes to accessibility, when I use tab, the focus goes typically outside the side drawer, and the focused content is hidden behind it.

so, my opinion is to be opened until the user focus on something outside it then it should be closed