IEEE-NITK / corpus

A Django-based web application for managing all things IEEE NITK!
https://ieee.nitk.ac.in
2 stars 7 forks source link

Added basic page about design system #10

Closed anirudhprabhakaran3 closed 1 year ago

anirudhprabhakaran3 commented 1 year ago

Description

Adds a design system page for designing interfaces on Corpus

Dependencies

Dependencies on CDN links to DaisyUI and Tailwind CSS

Type of Change

What types of changes does your code introduce? Put an x in the boxes that apply

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change) Put an x in the boxes that apply


Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

image

nishant-nayak commented 1 year ago

The tests seem to be failing. It looks like you've defined the app internal (in internal.apps.InternalConfig), but I don't see any code related to the internal app. Is that something you forgot to push or a framework you're using?

anirudhprabhakaran3 commented 1 year ago

Yeah kinda weird, need to figure it out. The same tests are running on my local system and passing, need to see why this is failing.

nishant-nayak commented 1 year ago

Closing this PR because the entire design system is changing with the introduction of SvelteKit and Storybook from #12 . Please make a new branch off the latest main when you're working on the updated design system. @anirudhprabhakaran3

anirudhprabhakaran3 commented 1 year ago

Yup, will do. Deleting branch too!