IEEE-NITK / corpus

A Django-based web application for managing all things IEEE NITK!
https://ieee.nitk.ac.in
2 stars 7 forks source link

Migrating pages #68

Closed imApoorva36 closed 10 months ago

imApoorva36 commented 11 months ago

Description

Made SIG Pages

Fixes # (issue)

Dependencies

List any dependencies that are required for this change.

Type of Change

What types of changes does your code introduce? Put an x in the boxes that apply

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change) Put an x in the boxes that apply


Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

imApoorva36 commented 11 months ago

Couple of requests:

  • Can you create a DB dump (similar to the config_db.json file in the corpus folder) with the SIG data? You can achieve this by running python manage.py dumpdata config. Overwrite the current config_db.json file with the SIG data added. This will help all of us have the same static data and have a copy for easy deployment into production.
  • Can you add the SIG links to the Footer (check corpus/templates/components/general_footer.html)? I think the About Us link is also missing, can you add that too?
  • Can you add the SIG links to the Header navbar as well (check corpus/templates/components/general_dropdown.html)? There is also an issue to update the navbar to something similar to the old website, if you'd like to take that up then you can close that issue in this PR itself, else just add it to the file mentioned above. The update to navbar is tracked in Update Navbar to be similar to old Navbar #75 .

Got it, I'll take up #75 too .

imApoorva36 commented 11 months ago

Will add Update Navbar to be similar to old Navbar #75 in a new commit

imApoorva36 commented 10 months ago

@Vignaraj-pai Do let me know if any other change too is required for the SIG data, modified above changes for now

imApoorva36 commented 10 months ago

Finally got to review the UI and suggest UI related changes. I hope this is the last set of reviews for this PR. Thanks for continuing work on this!

I've reverted with all the suggested changes, and really Sorry for the minor issues everytime, Next time when I commit code, I will follow the code workflow with more attention

imApoorva36 commented 10 months ago

Added a few more comments. Try switching themes and switching viewport sizes while testing.

I have reverted with these changes in a new commit, forgot to reply the other day after the commit...

Please do look into it when you're available, and I hope this time I've looked over all edge cases too...