search

IEEE-RVCE / hack-it-right

https://hack.ieee-rvce.org/
MIT License
1 stars 1 forks source link

collaboration section added #19

Closed sannidhi-s-shetty closed 2 years ago

sannidhi-s-shetty commented 2 years ago

8

chrisvrose commented 2 years ago

Changes look good overall from my side, except for package-lock.json I assume it is an upgrade and we have to deal with the change. Can we ensure following from here all of us have an updated npm?

npm i -g npm@latest
Prajwalprakash3722 commented 2 years ago

Image placement kinda looks weird to me, nvm will fix and push

Prajwalprakash3722 commented 2 years ago

images were being imported from the relative path, it is not adviceable to import like this

<img src="./images/IEEE-CS_LogoTM-orange.png" alt='IEEE Computer Society' />

It is always advisable to import it as a module and directly link it with the src

import CompSocLogo from  "./images/IEEE-CS_LogoTM-orange.png";

<img src={CompSocLogo} alt='IEEE Computer Society' />