search

IEEE-VIT / Howzat

This website is aimed to make cricket fans stay updated on the current ICC Men’s Cricket World Cup 2023. A beginner friendly repository to help users learn and contribute towards open source
https://ieee-cwc.onrender.com/
MIT License
6 stars 16 forks source link

Fix: ICC WC logo #35

Closed Ronit-gurjar closed 1 year ago

Ronit-gurjar commented 1 year ago

hey @NSmonish

I have added the logo (ICC-WC-2023.png) and implemented necessary requirements to make it look proper🔥

BEFORE :-

Screenshot_20231014_181321

AFTER :-

Screenshot_20231014_181411

Ronit-gurjar commented 1 year ago

@NSmonish

I have fixed the issue. the issue was caused due to following block of code :- image

I found about this error after enhancing the old logo😂 now the logo looks x2 good.

Suggestion :- i would recommend changing the background-color from #320073 to #1D0042 for a better contrast, in body and header

NSmonish commented 1 year ago

@NSmonish

I have fixed the issue. the issue was caused due to following block of code :- image

I found about this error after enhancing the old logo😂 now the logo looks x2 good.

Suggestion :- i would recommend changing the background-color from #320073 to #1D0042 for a better contrast, in body and header

yes the opacity is the problem, change it to 1.0 and create a PR. The background colour is made according to the colour code of official icc wc 23.

Ronit-gurjar commented 1 year ago

@NSmonish the above PR already contains the changes

i removed that block completely, do you want me to add it with opacity of 1?

Ronit-gurjar commented 1 year ago

@NSmonish I have fixed the issue. the issue was caused due to following block of code :- image

I found about this error after enhancing the old logo😂 now the logo looks x2 good.

Suggestion :- i would recommend changing the background-color from #320073 to #1D0042 for a better contrast, in body and header

yes the opacity is the problem, change it to 1.0 and create a PR. The background colour is made according to the colour code of official icc wc 23.

Changes Done

NSmonish commented 1 year ago

@NSmonish I have fixed the issue. the issue was caused due to following block of code :- image

I found about this error after enhancing the old logo😂 now the logo looks x2 good.

Suggestion :- i would recommend changing the background-color from #320073 to #1D0042 for a better contrast, in body and header

yes the opacity is the problem, change it to 1.0 and create a PR. The background colour is made according to the colour code of official icc wc 23.

Changes Done

Your Pull request on the logo issue will be merged. Thank you for contributing. #StayInTheLoop #IEEE-VIT