IEEE-VIT / hackfest-flutter

An app to find repositories on Github and to view the various contributors to said repos.
MIT License
30 stars 43 forks source link

Updated display according to user default theme #56

Closed 0kt1 closed 11 months ago

0kt1 commented 11 months ago

Issue:

Implement display according to user default system theme

Changes made

How does the solution address the problem

This PR updates the app to follow the system's default theme and offers users the choice of light, dark, or system default themes.

Linked issues

Resolves #47

dk-a-dev commented 11 months ago

@0kt1 please try to pull from master and resolve merge conflicts ASAP Your PR is under review

dk-a-dev commented 11 months ago

We have added new lint rules which will produce a lot of warnings try to first resolve conflicts and then refactor a/c to warnings, if u need my help message me, then I will continue ur PR review @0kt1

0kt1 commented 11 months ago

Hey @dk-a-dev , I have resolved the conflicts and refactored the code according to lint rules. Could you please review it? Thanks.

dk-a-dev commented 11 months ago

Please pull from the origin main once so that ur branch gets updated with master commits this may cause merge conflicts but I will solve them once u pull and iff face issues le me know git pull origin master

0kt1 commented 11 months ago

Hey @dk-a-dev, I am not able to get the master commits. It's showing it's already up-to-date.

dk-a-dev commented 11 months ago

@0kt1 sorry for the repo lockdown, we were fixing the issue of repo not showing up for hacktoberfest, its fixed now

0kt1 commented 11 months ago

Fine. @dk-a-dev, can you please review my PR and approve it, or are there any changes that need to be made?

dk-a-dev commented 11 months ago

@0kt1 is that settings colour issue fixed, if that fixed this pr will be merged

0kt1 commented 11 months ago

@dk-a-dev , Actually, there is no issue with the settings icon, it's changing color in each mode.

dk-a-dev commented 11 months ago

@0kt1 ...updates on fixes

0kt1 commented 11 months ago

@dk-a-dev ,I updated the final fixes.

0kt1 commented 11 months ago

@dk-a-dev ,Thank You!