Search Page UI updated - Githubissues

IEEE-VIT / hackfest-flutter

An app to find repositories on Github and to view the various contributors to said repos.

MIT License

30 stars 43 forks source link

Search Page UI updated #80

Closed SarveshChavan closed 10 months ago

SarveshChavan commented 10 months ago

Linked Issue #77

Changes made

Changed the UI according to the new flutter design, also due to some bugs and errors the color scheme is changed a little bit.

How does the solution address the problem

This PR will focus on the UI enhancement of the search repo page and will give the user a better experience of using the App.

SarveshChavan commented 10 months ago

@dk-a-dev sorry for the delay. Can you please review it ASAP so that this contribution will be counted in hacktoberfest ?

dk-a-dev commented 10 months ago

Yup sure buddy i am on it, I also want to get it merge before tomo plz be active if I post a review to make quick fixes if any

dk-a-dev commented 10 months ago

the new UI doesnt look neat and there bugs in colour scheme
the repo card needs a lot of improvement, its not like one in design @SarveshChavan

dk-a-dev commented 10 months ago

@SarveshChavan if u are struggling with something let me knw, i can help, @Lomesh21 is also willing to help

SarveshChavan commented 10 months ago

Sorry for the mistake but when I click wo dark theme in my machine the theme is changing properly and also the issue with repo card is because we can't fet h the followers and the contact details from our api (the response of get repos method). Also the slimy widget has some constraints of its own such as the cards height should be 150 minimum and if I increase it for the other 2 fields(followers and contact) the card height get increased and when we increase the slimy widget card height it produces an extra blank card after each slimy widget. But I'll still try to make it possible and I'll let you know. I'll change it tomorrow and also will take the pull to avoid conflict.

SarveshChavan commented 10 months ago

The switch button working fine the theme is getting changed, @dk-a-dev review the PR, and also the changes that have been made in the contributors page and drawer need to be changed according to theme.