IEEE-VIT / templa-rs

One-Stop Solution for all boilerplate needs!
MIT License
28 stars 22 forks source link

feat: added owner tag to the submodules.json so I can use it for prog… #24

Closed mooyg closed 2 years ago

mooyg commented 2 years ago

…res bar

mooyg commented 2 years ago

Did this cause I need owner tag to get the repo size from the github api before hand (also you can close the previous PR I'll make a new one)

mintbomb27 commented 2 years ago

@mooyg Could you clarify why you can't parse the owner from the Repo URL?

mooyg commented 2 years ago

Uh I mean I can write logic for that but why waste time on that when I can just add one more field in json and avoid hassle?

Mannan-Goyal commented 2 years ago

@mooyg You don't need to write any parsing logic, you can just take the sub-string from the end of the link and append it to the API URL. So u can take IEEE-VIT/templa-rs from the end of https://github.com/IEEE-VIT/templa-rs/ and append it to https://api.github.com/repos/ to finally make https://api.github.com/repos/IEEE-VIT/templa-rs. It's much more easier for people who add templates & efficient than your current method, I request you to follow this.

mooyg commented 2 years ago

@mooyg You don't need to write any parsing logic, you can just take the sub-string from the end of the link and append it to the API URL. So u can take IEEE-VIT/templa-rs from the end of https://github.com/IEEE-VIT/templa-rs/ and append it to https://api.github.com/repos/ to finally make https://api.github.com/repos/IEEE-VIT/templa-rs. It's much more easier for people who add templates & efficient than your current method, I request you to follow this.

Ok sure

mintbomb27 commented 2 years ago

Closing the PR as another implementation of the feature was requested.