search

IEEE-VIT / templa-rs

One-Stop Solution for all boilerplate needs!
MIT License
28 stars 22 forks source link

[BUG] Unable to release templa-rs #37

Closed DarthBenro008 closed 3 years ago

DarthBenro008 commented 3 years ago

Describe the bug

Currently, templa-rs uses submodules.json file to load and display the available templates, but while creating a release, this is not included, hence it isn't ready to ship solution yet.

To Reproduce Steps to reproduce the behaviour:

  1. Build templa-rs using cargo build
  2. Place the binary in a directory where there isn't any submodules.json

Expected behaviour It should at least have a minimal amount of repos already pre-built for user to select

Screenshots image

Desktop (please complete the following information):

Proposed Solution(s)

  1. Refer to the submodules.json file from GitHub while running the command
  2. Create a small key/value storage and store the data (serialize and deserialize on startup)
mintbomb27 commented 3 years ago

Hey @DarthBenro008

We had raised this issue(#7) earlier, and subsequently we merged #16 to solve it. As of now, we're fetching the submodules.json dynamically using the Github API and hence the binary doesn't have to be in a folder with the submodules.json. It shall only be maintained in this repo remotely.

Please pull from master and try reproducing the bug again, as I was not able to do the same.

DarthBenro008 commented 3 years ago

@mintbomb27 , I had pulled from the main branch on commit https://github.com/IEEE-VIT/templa-rs/commit/5b3129cab607ec940644e3081347156588fce9d2 .

Is there a possibility of an request failure?

mintbomb27 commented 3 years ago

@DarthBenro008 If there was a request failure, it would've shown the same. From your screenshot, it also shows that you're using the old UI as well.

And the default branch is master? Not main?😅

DarthBenro008 commented 3 years ago

Oops, it seems there was some aggressive cargo build cache. removing target and re-building seemed to produce latest build :+1: