search

IEEE-VIT / termiboard

A smart CLI Dashboard to fetch cpu, memory and network stats!
MIT License
35 stars 16 forks source link

(Bad PR) Implemented GetCpuUsage() function #9

Closed S-Maciejewski closed 4 years ago

S-Maciejewski commented 4 years ago

This pull request relates to the issue #6

The GetCpuUsage() method in cpu.go was implemented using gopsutil library's cpu.Percent function. The result is displayed by ResultPrinter function as a percentage of overall CPU usage.

DarthBenro008 commented 4 years ago

@S-Maciejewski please resolve your merge conflicts.

S-Maciejewski commented 4 years ago

@S-Maciejewski please resolve your merge conflicts.

It is now resolved. However, I am not sure if perhaps the unused function GetCpuTemperature() should be commented out, as I can see golangci-lint having problems with it

DarthBenro008 commented 4 years ago

Yes , all unused functions must be commented off and the code needs to pass the lint test. Please make the changes accordingly and kindly squash your commits.

S-Maciejewski commented 4 years ago

Apologies for the doubled PR, I could not find a way to reopen this after accidentally closing it. Just treat it as spam. Sorry again, I'm still quite new to this kind of workflow