Closed vinicius0197 closed 6 years ago
Code Climate has analyzed commit 0857ad66 and detected 2 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Style | 2 |
The test coverage on the diff in this pull request is 42.8% (80% is the threshold).
This pull request will bring the total coverage in the repository to 93.1%.
View more on Code Climate.
@alexandrebarbaruiva Concertei os erros do Travis, mas o codeclimate reclamou do tamanho de uma das funções. Seria melhor colocar aquela lista de contatos para fora da função?
E outra coisa, eu classifico esse PR como New Feature ou New Dialog?
Merging #37 into master will decrease coverage by
5.26%
. The diff coverage is50%
.
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 100% 94.73% -5.27%
==========================================
Files 2 2
Lines 102 114 +12
Branches 4 4
==========================================
+ Hits 102 108 +6
- Misses 0 6 +6
Impacted Files | Coverage Δ | |
---|---|---|
bot/application.py | 92.1% <50%> (-7.9%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 48e0b04...d5d4060. Read the comment docs.
@vinicius0197 como new feature!
Merging #37 into master will decrease coverage by
6.89%
. The diff coverage is42.85%
.
@@ Coverage Diff @@
## master #37 +/- ##
========================================
- Coverage 100% 93.1% -6.9%
========================================
Files 2 2
Lines 102 116 +14
Branches 4 4
========================================
+ Hits 102 108 +6
- Misses 0 8 +8
Impacted Files | Coverage Δ | |
---|---|---|
bot/application.py | 89.74% <42.85%> (-10.26%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1be708d...0857ad6. Read the comment docs.
New Feature Submissions:
To run tests locally, use
make
if you're on Mac or Linux.New Dialog Submissions:
User messages have
- -
, bot messages have-
test_dialogs
?Changes to Core Features: