IEEEComputerSocietyUNB / ProjetoChatbot

A telegram bot to help you deal with emotions on a daily basis
MIT License
12 stars 3 forks source link

Remove test_if_bot_is_unbchatbot test #44

Closed vinicius0197 closed 6 years ago

vinicius0197 commented 6 years ago

PR Description

Fix issue #42 .

New Feature Submissions

To run tests locally, use make if you're on Mac or Linux.

  1. [ ] Does your submission pass all the tests?
  2. [ ] Have you lint your code locally prior to submission?
  3. [ ] Have you written proper tests to your added code?

New Dialog Submissions

User messages have - -, bot messages have -

  1. [ ] Does all your user messages have lower letters?
  2. [ ] Have you lint your dialogs locally prior to submission?
  3. [ ] Have you written proper tests to your added dialogs on test_dialogs?
  4. [ ] Does your dialog have an existing category? If not, did you create it?

Changes to Core Features

codeclimate[bot] commented 6 years ago

Code Climate has analyzed commit 1e6be2b0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 93.2% (0.0% change).

View more on Code Climate.

codecov[bot] commented 6 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   93.33%   93.22%   -0.12%     
==========================================
  Files           2        2              
  Lines         120      118       -2     
  Branches        4        4              
==========================================
- Hits          112      110       -2     
  Misses          8        8
Impacted Files Coverage Δ
bot/application.py 90% <ø> (-0.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44cfa6b...1e6be2b. Read the comment docs.

alexandrebarbaruiva commented 6 years ago

Remove também a função que estava sendo testada. É para a cobertura de testes manter a mesma, tendo em vista que vc só está removendo funcionalidade

vinicius0197 commented 6 years ago

@alexandrebarbaruiva Removi a função verify_bot, mas o code coverage continua reclamando. Alguma ideia?

alexandrebarbaruiva commented 6 years ago

tá certinho agora, essa diminuição é só pq cada linha de código agora tem uma porcentagem maior

alexandrebarbaruiva commented 6 years ago

só melhora a descrição na próxima e marca as questões do template da PR