Wrong colorspace detection in ffmpeg 5.1

IENT / YUView

The Free and Open Source Cross Platform YUV Viewer with an advanced analytics toolset

http://ient.github.io/YUView

Other

1.88k stars 369 forks source link

Wrong colorspace detection in ffmpeg 5.1 #474

Closed ChristianFeldmann closed 2 years ago

ChristianFeldmann commented 2 years ago

Describe the bug Problem with colorspace detection in the latest ffmpeg 5.1 release. Looks like the wrong colorspace is used or the data arangement is wrongly determined.

To Reproduce Steps to reproduce the behavior:

Open a YUV 4:2:2 10 bit file using ffmpeg 5.1

Screenshots If applicable, add screenshots to help explain your problem.

Version (please complete the following information):

OS: Any OS

ChristianFeldmann commented 2 years ago

I was able to reproduce this also with FFmpeg 5.0. So this is probably related to the ffmpeg 5 interface

ChristianFeldmann commented 2 years ago

Found it. The pixel format can be gotten from the "new" codecpar in the vide stream. This was introduced a while back but now finally in 5.0 the old interface with the 'codec' struct was removed (it was already deprecated a while). But I forgot to change this for the pixel format. The fix is in deveolp. (The branch protection does not seem to be set up correctly and I accidentally pushed it directly on develop).