IETF-OPSAWG-WG / draft-ietf-opsawg-pcap

PCAP next generation file format specification
Other
272 stars 62 forks source link

Add if_tzone option specifications #148

Closed ds-j-ot closed 1 year ago

ds-j-ot commented 1 year ago

This PR is a proposal on how to store time zone information in the respective if_tzone option.

guyharris commented 1 year ago

That doesn't provide sufficient information to correctly convert times to local time in the locale where the capture was done; as the proposed example states, "Example: '3C 00 3C 00' for Europe/Berlin with daylight saving time.", so there's a 1-hour positive offset from UTC, and an added 1-hour positive offset during DST/summer time, but no indication is given as to when changes between standard time and DST/summer time occur.

Perhaps we should just deprecate if_tzone and add, instead, a string option containing a tzid, so the example would be "Example: Europe/Berlin for Europe/Berlin". :-)

guyharris commented 1 year ago

In e63374c8aa03fdfd296042ff92c4fc565b2b2980 I've added an if_iana_tzname string option to specify an IANA time zone database timezone name, and deprecated if_tzone.