Closed chaudron closed 4 years ago
Not sure if I had to add my name as an editor if I added text. If not I can remove it, no problem.
Also for some reason, I'm not getting emails from the pcap-ng-format mailing list. I've asked the pcap-ng-format-owner to verify I'm properly registered but got no update. So I will monitor the list manually, but if you do send related emails there I would appreciate it if you can put me on CC directly.
Eelco Chaudron notifications@github.com wrote:
Not sure if I had to add my name as an editor if I added text. If not I can remove it, no problem.
Generally, in an IETF document, we would acknowledge all contributors in the Acknolwedgements section, but only list the lead authors/editors in the heading. There is a guideline for five authors only on an RFC, and we'll justify or prune names if/when we get closer to that stage.
-- ] Never tell me the odds! | ipv6 mesh networks [ ] Michael Richardson, Sandelman Software Works | IoT architect [ ] mcr@sandelman.ca http://www.sandelman.ca/ | ruby on rails [
General question what does "epb" stand for?
General question what does "epb" stand for?
It stands for "Enhanced Packet Block", which is the most commonly used block type to store each packet.
General question what does "epb" stand for?
It stands for "Enhanced Packet Block", which is the most commonly used block type to store each packet.
Thanks for explaining that! :-)
Generally, in an IETF document, we would acknowledge all contributors in the Acknolwedgements section, but only list the lead authors/editors in the heading. There is a guideline for five authors only on an RFC, and we'll justify or prune names if/when we get closer to that stage. …
Ok, will leave it in for now, or let me know and I'll remove/move my name.
Anything pending from my side, or something I can do to get this merged?
Commited the changes suggested by @guyharris as I got no further feedback. Please let me know if I need to change more...
@guyharris pushed the suggested changes and fixed one other issue with a duplicate ecb_option number. Anything else?
@guyharris anything else I can do to speed up the acceptance of this change? I've done a rough implementation in WireShark to display these new fields.
@guyharris @mcr anything I can do to speed up this merge request? Asking as I have a project that would really benefit from this.
@guyharris @mcr anything I can do to speed up this merge request? Asking as I have a project that would really benefit from this.
I'm OK with it; @mcr, are you OK with @chaudron's appearance in the authors list?
Thanks a lot for merging this!!
Signed-off-by: Eelco Chaudron echaudro@redhat.com