search

IETF-OPSAWG-WG / lxnm

L3 VPN Yang Model
8 stars 11 forks source link

Externalize ESes #349

Closed boucadair closed 3 years ago

sbarguil commented 3 years ago

Just one minor comment in the BESS ethernet-segment yang they have included the BGP configuration as part of the ethernet-segment:

 container bgp-parameters {
        description "BGP parameters";
        container common {
          description "BGP parameters common to all pseudowires";
          list rd-rt {
            if-feature ethernet-segment-bgp-params;
            key "route-distinguisher";
            leaf route-distinguisher {
              type rt-types:route-distinguisher;
              description "Route distinguisher";
            }
            uses rt-types:vpn-route-targets;
            description "A list of route distinguishers and " +
                        "corresponding VPN route targets";
          }
        }
      }

For me is ok to maintain it outside as part of the EVPN Service. However if we can increase the reusability and apply the same BGP configuration to all the Ethernet-Segments it could be included.

After a brief review In devices, like Juniper and Nokia the BGP parameters are outside the Ethernet Segment:

route-distinguisher 192.0.2.73:0
ethernet-segment "ESI-7413" create
    esi 01:74:13:00:74:13:00:00:74:13
    es-activation-timer 0
    service-carving
        mode auto
    exit
    multi-homing single-active
    sdp 34
    no shutdown
exit
boucadair commented 3 years ago

Thanks, Samier.

I remember that Moti suggested also to add RT/RD but with a lower priority than the member list.

At least for the L2NM, I don't see that is needed because the required information is captured under l2vpn-service. I suggest that we keep the modularization with the same scope we have in the current version of L2NM.