IETS3 / iets3.opensource

Open Source Parts of IETS3
Apache License 2.0
44 stars 22 forks source link

Migrate to 2024.1.1 #1123

Closed alexanderpann closed 5 days ago

alexanderpann commented 1 week ago

There is only one annoying issue in MPS: youtrack.jetbrains.com/issue/MPS-36888/java.lang.UnsupportedOperationException-not-implemented

Model checking was never fully enabled. I disabled it so that it doesn't throw errors.

arimer commented 5 days ago

@alexanderpann looks like your mentined YT issue is closed. 👍🏼

arimer commented 5 days ago

Why are all groups set to update in background: true?

grafik
alexanderpann commented 5 days ago

The updating of groups and actions usually takes place on the EDT/UI thread. If this takes a long time, the UI is frozen. With this MPS version, you even get a fatal error if the update takes too long.

arimer commented 5 days ago

In TestAsyncFromSingleThreaTestAsyncFromSingleThreadd you have added a new test. How do you ensure that this test does not remove anything that is required by any other test in that model?

test cleanup { 
  execute command in EDT with project.getRepository() { 
    model.roots(DummyISolvable).forEach({it => model/.removeRootNode(it); }); 
  } 
}
alexanderpann commented 5 days ago

It is executed after the other test. The cleanup in this model still is not perfect by the way but better than before. The problem is that in the before and after test methods I can't access the model, so I can't do any proper cleanup. If you use a try-catch-finally block you mess up the asserts as far as I remember.

alexanderpann commented 5 days ago

How do you ensure that this test

The test is always executed after the other test. We can't use the before and after test blocks because they are static methods that, for example, also don't have access to the model.

arimer commented 5 days ago

StyleRegistry.getInstance() is now deprecated, should we use an alternative if one is available?

According to the code there is a way around it.

arimer commented 5 days ago

Oh, and maybe update the readme to anounce that master is on 2024.1

arimer commented 5 days ago

I've created a ticket ot not forget about it: https://github.com/IETS3/iets3.opensource/issues/1131