search

IEvangelist / dotnet-github-actions-sdk

The unofficial GitHub ToolKit for developing GitHub Actions with .NET.
https://davidpine.net/blog/github-actions-sdk/
MIT License
55 stars 7 forks source link

Consider renaming #5

Open js6pak opened 6 months ago

js6pak commented 6 months ago

Having a GitHub. prefix makes it look like it's an official GitHub project, which it's not. The fact that the c# project name, nuget package id and github repository names are all different is quite bizzare aswell. My vote goes for ActionsToolkitSharp.

IEvangelist commented 6 months ago

Yeah, I was back and forth a lot on the naming. The GitHub. prefix isn't reserved, so I went with that. What about GitHubActions. instead?

js6pak commented 6 months ago

GitHubActions. still sounds too generic, I feel like having a more unique name for the project would be both less confusing and better for searchability.

IEvangelist commented 6 months ago

GitHubActions. still sounds too generic, I feel like having a more unique name for the project would be both less confusing and better for searchability.

I was referring specifically to the NuGet package and project names:

Current name Proposed name
GitHub.Actions.Core GitHubActions.Core
GitHub.Actions.Glob GitHubActions.Glob
GitHub.Actions.Octokit GitHubActions.Octokit

I'm not a fan of the suffix *Sharp in the name and Toolkit might make sense. Maybe something like this: GitHubActions.Toolkit.Core?

js6pak commented 6 months ago

At least for me, GitHubActions.Toolkit.Core seems to suggest that it's the Core subcomponent of the Toolkit library owned by the GitHubActions organization.

Something like GitHubActionsToolkit.Core where Core is the subcomponent of GitHubActionsToolkit library would work better. It's still a little generic but it should be fine.

IEvangelist commented 6 months ago

Yeah, I'm good with that. I'll make the name change soon. Thanks for the suggestion.