IFB-ElixirFr / FAIR-checker

Web tool to assess FAIR principles and promote their implementation
MIT License
19 stars 6 forks source link

Testing MassBank records takes long #82

Open sneumann opened 2 years ago

sneumann commented 2 years ago

Hi, I wanted to check https://massbank.eu/MassBank/RecordDisplay?id=PB000166 which has some bioschemas in it. Takes several minutes and does not complete, still spinning. I don't claim we have the best bioschemas markup (issues you observe please report to https://github.com/MassBank/MassBank-web/issues?q=is%3Aissue+is%3Aopen+label%3AJSON-LD), so we are a good test for the robustness of FAIR-checker :-) Yours, Steffen

noirot commented 2 years ago

Hi, I've got the same pb on https://asterics.miat.inrae.fr/. I added fair informations with following lines in my web app:

<script type="application/ld+json">[
        {
          "@id": "https://bio.tools/asterics/op_1/in_1",
          "@type": [ .....

But it never ends. As I never use those kinds of information I don't know if the pb come from my web app or from fair-checker

thomasrosnet commented 2 years ago

Hello,

Thank you for submitting an issue @sneumann ! It is an issue on the FAIR-Checker side, it should be fixed in the next release of FC.

On the other end @noirot , it seems that that the problem is on both sides, there is an error in the json-ld embedded in the website: The property "http://purl.org/dc/t erms/conformsTo" is incorrect because there is a whitespace in "terms" between the t and e.

Could you try to fix that please ? It will probably not work right away in FAIR-Checker and it will be needed to wait the next release of FC, it should be done this week or the next.

Thanks for your feedbacks.

Thomas

albangaignard commented 1 year ago

which has some bioschemas in it

Thanks very much @sneumann and sorry for this very late answer. I've been looking at the embeded JSON-LD and I tried to validate it through the JSON-lD playground (https://json-ld.org/playground/). It seems that the @context cannot be resolved in http : Capture d’écran 2022-09-28 à 17 18 29

But it works with https : Capture d’écran 2022-09-28 à 17 19 22

This issue is discussed here : https://github.com/schemaorg/schemaorg/issues/2853 .

Could you try to update your web application so that @context points to https://schema.org/ ?

sneumann commented 1 year ago

Ah, that might explain it. @meier-rene could have a look at that. Yours, Steffen