search

IFRCGo / cbs

Red Cross: Community-Based Surveillance
https://cbsrc.org/
Other
101 stars 110 forks source link

Make navigation project deployable #402

Closed Virrum closed 6 years ago

Virrum commented 6 years ago

Description

We need this project to be deployable so that it can be used.

The deployable parts will be the output in ./dist after webpack -p

beatfactor commented 6 years ago

@Virrum @karolikl Could you provide some more background into what should be done here?

alexanderhoset commented 6 years ago

I can try to help out

source/navigation need to have a docker file and be deployable

FROM node:latest AS angular-build WORKDIR /Web/ RUN ["npm", "install", "-g", "yarn"] RUN ["npm", "install", "-g", "webpack"] RUN ["yarn","global", "add", "typescript"] COPY . /src WORKDIR /Web/ RUN ["yarn", "install"] RUN ["webpack", "build", "--p"] FROM nginx:1.13-alpine COPY --from=angular-build /Web/src/dist /usr/share/nginx/html

Something like that but also need all the other folders and files

appveyor.yml /deploy docker-compose.yml

beatfactor commented 6 years ago

@alexanderhoset ok thanks, seems straightforward enough.

beatfactor commented 6 years ago

@alexanderhoset @karolikl Ok, I had a look here, but l don't really see how this module, running in its own container, will be integrated with the rest of the modules, which seem to have their own navigation. So I was wondering what that plan might be regarding the integration and packaging of all the modules?

beatfactor commented 6 years ago

Another thought I had is maybe we should gather all the frontend code together, possibly even to a separate repo?

alexanderhoset commented 6 years ago

@beatfactor there is multiple ways to make it work, look at #403 for possible ways described by @Virrum @Virrum is working to make a poc using the navigation context included in admin

Idea is like this image

What he is working on is the top bar and not the internal context nav

alexanderhoset commented 6 years ago

I will revisit the the frontend merge idea after the MVP

The reason we did it was to make the bounded-contexts independent, but you are not the first to bring it up(me included). We need to look at the pros and cons . Thanks for your input

Virrum commented 6 years ago

oh, sorry, haven't seen this either. I'm not good at the github notifications apparently . Sorry.

karolikl commented 6 years ago

Sorry for the late reply!

This shouldn't be deployed into its own container, should it? It will have to be included into each of the existing frontend containers, or am I misunderstanding something here?