IFRCGo / go-api

MIT License
14 stars 6 forks source link

Deployment category data cleanup #1020

Open JonathanGarro opened 3 years ago

JonathanGarro commented 3 years ago

Is your feature request related to a problem? Please describe. This request is related to issue 903. In reviewing the available deployment data that is in the system now (as of the time of this writing, Molnix integration is not yet live, but I'm assuming that connection will only push new data rather than have an impact on existing data), there is a huge discrepancy in how data is stored about what folks' roles were. As an example, see the attached file and scroll to column DF ("Role"), then examine the values. It's clear that before Molnix, these alerts were just plain text entry fields, as the same role can sometimes be written a dozen different ways, and sometimes with typos. See Field Coordinator as an example:

Screen Shot 2021-02-24 at 3 29 17 PM

This makes reporting problematic. I had a user on my team looking to do some analysis on this data and can't because there isn't a clean set of values to group by.

Describe the solution you'd like Would look to the developers to give me the best way to do this. For the actual disambiguation and cleanup, I'd recommend just selecting the relevant columns, creating a new spreadsheet, and adding a column to map the each one to the list from Molnix, to ensure historical data matches the new stuff.

tovari commented 3 years ago

HI @anamariaescobar, do you know, if there is a list of possible deployment roles in Molnix? Would you able to provide that?

@JonathanGarro, I agree, I would add an additional Molnix-role to the database if possible, where we could map the legacy roles.

szabozoltan69 commented 3 years ago

According to Paola's request we could put a 'description', to MolnixTagSerializer, so that in .../api/v2/personnel/... that would be sent:

      "molnix_tags": [
        {
          "id": 31,
          "molnix_id": 19,
          "name": "MENA",
          "description": "Middle East & North Africa Regional Office",  !!!!!!!!!!
          "color": "",
          "tag_type": "regular"
        },
        {
          "id": 68,
          "molnix_id": 228,
          "name": "SHELTER",
          "description": "Shelter & Settlements", !!!!!!!!!!!
          "color": "",
          "tag_type": "regular"
        },

Deployed to dev + production.

nanometrenat commented 8 months ago

@anamariaescobar @ypyelab Is this ticket still relevant given recent Molnix/GO integration changes? Cheers