IFRCGo / go-api

MIT License
13 stars 6 forks source link

Move deployment (terraform, helm, azure pipeline) to another repo #1726

Open geohacker opened 1 year ago

geohacker commented 1 year ago

The continuous deployment work that is underway in #1725 is currently tied to this repository along with the codebase. It will be good to make this a separate repo so that:

  1. Builds are faster while debugging deploys
  2. Less chances of accidental deploys
  3. Easier to maintain application code and deployment code separately

This means that we will:

  1. Move the deploy folder https://github.com/IFRCGo/go-api/tree/terraform/deploy to a new repo
  2. Make the azure pipelines connection from this new repo
  3. Test

cc @batpad @szabozoltan69

szabozoltan69 commented 1 year ago

Great idea!

batpad commented 1 year ago

Thanks @geohacker .

Yea, this was likely an error in judgement on my part: it seemed great and convenient to have it all in a single code-base. But as we've worked on it, it is increasingly seeming much more practical / easy to deal with if we split this up into a separate repository.

This is mostly for developer experience and convenience, it's not a blocker to the current work. So we should probably finish testing the whole setup with the current approach and then we can weigh the benefits and also work involved to split this out into a separate repository.

batpad commented 1 month ago

This is close to ready!

@sunu could you outline a checklist for next steps here and things we need to ensure as we do this move? Thanks!

sunu commented 4 weeks ago

Outlining the next steps below to move infrastructure code out of this repository to go-deploy repository: