search

IFRCGo / go-api

MIT License
14 stars 6 forks source link

[PROD] Country plan to revoke #1848

Open szabozoltan69 opened 1 year ago

szabozoltan69 commented 1 year ago

Issue

In the country plan reader job there is no possibility to delete (revoke) an existing plan file. It can happen, than a NS would like to hide the already existing country plan.

We should consider to make it possible, that in case of no plan_url in the api, we should remove (or hide somewhere) the existing stored entity. Maybe 2 is_active fields are enough (1 for public, 1 for internal).

We could also consider to use the (already existing) is_publish flag on the Admin page. In case of false, the api does not show the (maybe existing) country plan files; there is a filter for that in the related viewset: .filter(is_publish=True) There are countries (126, 205), where there are plan files, but despite of that they can not be seen on frontend, due to the false is_publish flag, check e.g. this page, and the opposite (where exist visible plan file and is_publish is true) here.

szabozoltan69 commented 9 months ago

@tovari @batpad @thenav56 Could we please frame the exact conditions when a Country plan should be deleted/revoked? And what should be the action: real deletion or some kind of soft delete?