Closed geohacker closed 3 years ago
We've had an email from a user regarding two of the missing districts for Palau not being available when needed for field reports. Just noting here for reference but will already be covered by this ticket. Districts are: PW003,Kayangel PW013,Sonsorol
The reasons for the missing districts seems to vary with some being in disputed territories (e.g. Kosovo) and other that are simply missing from the GO database. For this release, we are prioritising adding the missing districts from independent nations. We will then review all districts as part of the wider geo-data review. Districts being added now:
ADMIN01COD | ADMIN01NAM | ADMIN00NAM |
---|---|---|
AG002 | Redonda | Antigua and Barbuda |
BS013 | Grand Cay | Bahamas |
BS031 | Spanish Wells | Bahamas |
MH002 | Ralik Chain | Marshall Islands |
MV004 | Central Province | Maldives |
MV005 | North Central Province | Maldives |
MV006 | North Province | Maldives |
MV007 | Upper North Province | Maldives |
MV002 | Upper South Province | Maldives |
PW003 | Kayangel | Palau |
PW013 | Sonsorol | Palau |
TV001 | Funafuti | Tuvalu |
TV002 | Nanumanga | Tuvalu |
TV003 | Nanumea | Tuvalu |
TV004 | Niutao | Tuvalu |
TV005 | Nui | Tuvalu |
TV006 | Nukufetau | Tuvalu |
TV007 | Nukulaelae | Tuvalu |
These have been imported to staging. Thanks @jhenshall and @GregoryHorvath!
@geohacker @GregoryHorvath - I've just noticed that the newly added districts here and for Nepal #1422 do not have a country_name
value in the API. I missed this before, as the front end functionality is fine and must work on ISO2 code? Would be a nice to have on staging, but definitely when adding to prod. 🙂
@jhenshall Nice catch. Yes, that's because the shapefile that we used to import Nepal districts didn't have anything in the COUNTRY
column. The import script will grab the name if that column is not null https://github.com/IFRCGo/go-api/blob/develop/api/management/commands/import-admin1-data.py#L79
On staging, I recommend you going ahead in the admin and adding these as fixing for just these would likely be a bunch of work programmatically.
If you'd like this to be fixed in production, can you fix this in the shapefile and share with us? We can add it when we release!
Thanks @geohacker. I've filled in the missing countries on staging and updated the country column in the shapefile to be used for prod.
@geohacker - I've added the updated shapefiles with COUNTRY
column populated to the same filepaths on dropbox (moved the old ones to archived
folder). Hopefully this means it will now carry across the country_name
attribute on prod.
@geohacker can you please close this if everything has been resolved on prod or create a new issue / clarify remaining bits?
This isn't entirely resolved and should go into 4.4 for @jhenshall to decide how we approach the missing districts.
Can we make country_iso
nullable in the districts table? This is actually a symptom of this issue that the districts table stores country name and iso separate to country table. I assume the broader fix is not possible this time round, so need to have nullable iso for disputed territories. Example screenshot of how one of the disputed territories should look:
@GregoryHorvath @geohacker @batpad
Remaining districts added in March 2021 - all districts from ICRC shapefile now in GO! 🎉
Here's a list of all districts that are missing or could be matched because the names are different / has unicode issues (related to #1456)
This is also related to #1464 #938