IFRCGo / go-frontend

MIT License
21 stars 5 forks source link

COVID Field Reports improvements #1797

Closed anamariaescobar closed 2 years ago

anamariaescobar commented 3 years ago

Is your feature request related to a problem? Please describe. A revision of the COVID-19 Field Report was conducted, these are the changes proposed per section:

1. Context

2. Situation 2.1 Numeric details (people)

3. Actions

4. Response

@tovari

tovari commented 3 years ago

Hi @mariam-yu, I would like to ask your opinion, what would be the best way to implement the following type of descriptions: "3.2 Actions taken by the IFRC Add: Description (inside the text box): In this section you can provide details as to how you have been working with the IFRC in this operation. To help in completing this section some prompting questions are below which are meant to function as a guide only: • What role has the IFRC been playing in this operation? • What actions has the IFRC taken to support this operation? • What are the recent changes in the actions taken by the IFRC since the last field report? • Are there any areas where you hope IFRC can support with?"

The description is long, it would not fit into the text box without scrolling, and it would disappear when starting to type. Would you suggest another solution? Maybe under the 'Actions taken by the IFRC' text, or as a tooltip? Or something else? There are a few other similar updates as well in this request, so it would be good to have a generic solution.

Thanks!

image

mariam-yu commented 3 years ago

@tovari So, here has been the logic so far (or what we should have aimed for):

I know that with the latter it wasn't always an example, but I think we should go in that direction, otherwise it is duplicate info.

So, what we could do is: a) Instead of the text you mentioned write an example matching that guideline and have it within the description box. b) Have a brief guideline under the title with a tooltip which will show the full text. The only thing is we don't have tooltips currently in the forms, but we do have them across the platform.

We could propose another option, such as "...description... read more" which would be the popup or expand option, but I'd be a bit hesitant to introduce this currently, as it would be a new thing, and I'm not sure how it would cascade down across the platform. The easiest would be a tooltip, though in this case we need to ensure the description itself is quite brief, followed up with a tooltip.

Hope this helps!

GergiH commented 3 years ago

@anamariaescobar I'll start to tick-off the things I'm done with locally so I/we can keep track better, if this is okay. I'll drop a comment whenever anything is pushed to staging.

anamariaescobar commented 3 years ago

That is perfect @GregoryHorvath thank youu!

GergiH commented 3 years ago

@anamariaescobar @mariam-yu Wondering if we should follow the same pattern for the tooltips as at other places, like this (don't mind the (i) icons are a bit off, their CSS will be fixed): image

Here you need to click the icon to get the tooltip, or if we really want hover-triggered tooltips here instead?

anamariaescobar commented 3 years ago

@GregoryHorvath from my side the easier and faster to implement, but I wonder what @mariam-yu thinks since we are adding the tooltips in a lot of places through the Field Report, for example the actions....

mariam-yu commented 3 years ago

@GregoryHorvath @anamariaescobar I think implementing tooltips works, but we probably should keep on click rather than hover to avoid having them too interactive when not needed. Also, do we need them in all the places? I agree that we should reduce the number. One way could be, for example in the image you sent, to combine the 3 into one and put next to the title, if the explanation is required for all. Hope this helps!

GergiH commented 3 years ago

@mariam-yu Oh damn that's actually the best idea. Thanks for the input, I'll keep them as clickables for the time being then and we'll see how it goes. I'll try to figure something out for the Actions parts when I get there.

GergiH commented 3 years ago

@anamariaescobar I deployed the ticked out stuff to staging.

A couple of notes to take:

cc @mariam-yu @batpad

anamariaescobar commented 3 years ago

Hey @GregoryHorvath!

Thanks for this, I have checked on staging and it looks great! (specially the tooltips on the actions, fantastic work!)

I have a couple of points to address:

  1. Situation 2.1 Numeric details (people)
  1. Actions

Also, I just thought about this, are the tooltips going to be translatable?

Please let me know if all of this is possible and sorry for some double work....

cc. @mariam-yu @batpad

GergiH commented 3 years ago

@anamariaescobar Again the checked out changes are out on staging.

I updated the descriptions/labels through https://dsgoproxyapp.azurewebsites.net/translation-dashboard which I forgot before

Change the tooltip on Number of NS Personnel Involved -->Number of personnel from the NS currently involved in the response (mobilized for this specific response).

This I also updated through the translation dashboard with the value in the original comment. So I didn't change it to this, but kept the above one in the first comment.

For the description fields that are still missing from the different sub-categories at the "3.1 Actions Taken by National Society Red Cross (if any)" part, once you figured out how to do them (I am sure you will), will it be possible to make them appear only if one or more of the actions of that category is ticked? (this is a wish list one, if that means a lot of work, there is no need to address it)

Can't really tell sorry, this depends on how we resolve adding the new fields in the first place.

External partners --> The drop down is not populated yet, also, can we add to the dropdown options provided before "Other governmental agencies" ? Supported/partnered activities --> Still not populated.

Sorry forgot to mention these are fillable from the Django Admin, but the values are added by now so you should see those in the dropdowns.

Since now we got down to 2 drop downs, can we make them appear in the same line? (again, wish list, so no need if that means extra work)

With the current design we seem to only have 1 label per line, so I'd say if we could have a combined label somehow here then this is doable. (you can see how this works for the Country and Region dropdowns in the form)

GergiH commented 3 years ago

@mariam-yu If you select Covid related event on the first step then you should see the changes on the staging site: https://dsgoproxyapp.azurewebsites.net/reports/new

Some of the relevant changes: image

Hovering action tooltips and our standard way of clickable tooltips image

@anamariaescobar had a suggestion if we could have these in 1 line somehow? image

Grouped together tooltips for visibility image

batpad commented 3 years ago

@karitotp there are some things still remaining from this ticket, but for all the things checked off by @GregoryHorvath and for the functionality in the screenshots above, would you be able to start testing the field report on staging?

We should check that the above functionality all works as expected when the Field Report is a COVID field report, and also that nothing is broken for field reports that are not COVID reports. Please add any questions to the ticket or you can ask @GregoryHorvath or me in Teams. Thanks much!

anamariaescobar commented 3 years ago

@GregoryHorvath

Sorry, I know we have change this text 3 times already, but just trying to make it as brief as possible! I promise this is the last time

Please let me know if I can help with translations, for the actions I will add them on staging for the first3 (first line under health) so @karitotp can test them and I can add them on the backend manually once we deploy to production,

cc @batpad @karitotp @mariam-yu

mariam-yu commented 3 years ago

@mariam-yu If you select Covid related event on the first step then you should see the changes on the staging site: https://dsgoproxyapp.azurewebsites.net/reports/new

Some of the relevant changes: image

Hovering action tooltips and our standard way of clickable tooltips image

@anamariaescobar had a suggestion if we could have these in 1 line somehow? image

Grouped together tooltips for visibility image

@GregoryHorvath Thank you for putting this together so detailed for me. It helped a lot to digest the changes. Here are a few comments. Hope it's clear, and I'm not missing anything.

Situation: Numeric details - subtext I am not sure if we have a style for this, but I think the text width should be shortened and a bit of padding on top.

Situation: Number of new cases... Not sure what the changes are here, but looks fine. Overall, in our designs we propose some fields to be next to each other and shorter fields to be shorter, as having such a large field for just one number may be strange. Also, just a tiny note, if we capitalize all the words in the titles, we should do it across :)

Situation: Situational Overview - subtext Also, on some other sections. This is super text heavy and will be very difficult to digest. probably better to split the text contextually. Have the minimum needed right up front and the rest (like examples) in a tooltip.

Actions: Actions Taken by NS - checkmark hovers I find these hovers very confusing. Didn't know why they popped up, where, related to what etc. Why can't we use the same tooltips next to each item?

Actions: External Partners / Supported partners We could have them side by side, like this:

Screen Shot 2021-02-09 at 11 47 55 PM

Response: Visible to - grouped tooltips This works. We'd probably need to "clean up" the style of the tooltip. The font doesn't need to be so bold and we could add some styling, but I guess for now works.

General: tooltips This is probably a bigger site-wide conversation, but in general it may be a good idea to add a little x to close the tooltips (since it's on click) and to not have them overlap, if one is open the other closes.

karitotp commented 3 years ago

@batpad @GregoryHorvath, all the thing are working correctly for COVID field reports and for NOT COVID reports. Some minor details are:

Hovering action tooltips and our standard way of clickable tooltips

For some reason in Assisted by RCRC Movement hovering text box does not disappear when I clicked on the other tooltips Screenshot from 2021-02-09 17-14-33

  • [ x] Add: Dropdown menu --> Details of Partner. Options: - MOH, WHO, UNICEF, WFP, Other UN agencies, Civil Society and NGO partners (Multiple Selection)

I did not find this

Also, In SITUATION section seems that the validation message is still displaying the previous titles of numeric details.

Screenshot from 2021-02-09 21-35-23

GergiH commented 3 years ago

@anamariaescobar Deployed the changes to staging, now the 3 "Notes" (since we already have "Description" fields for each Actions sections per organization, I called these "Notes") should show up. Also changed those descriptions you lastly mentioned. For the tooltip translations we could use a CSV I guess, currenty I simply added the english versions in a script as hardcoded values.

[
      [
        'National Society readiness',
        'Includes adapting community preparedness, response and DRR measures in view of the pandemic safety measures, especially when they are dealing with compounding disasters. Also includes adjusting contingency plans, updating Risk assessments identifying the different services that will be provided during the current disaster and how do these services fit into the National contingency plans.'
      ],
      [
        'National Society sustainability',
        'Includes identifying Core organizational budget to maintain the minimum structure of a National Society, available unrestricted reserves and unrestricted income and developing and executing business continuity plans.'
      ],
      ...
]

Where the 1 lines between each [ ] is the Action name that we're mapping them to, and after the , comma we have the tooltip text.

@mariam-yu

@karitotp Big thanks for the testing.

tovari commented 3 years ago

@GregoryHorvath, would you mind to remove the 'Description' text at 'Source (of figures) on the 2nd page? It is not required. Thanks!

karitotp commented 3 years ago

I checked again the functionalities for COVID FR and NOT COVID reports and all works good! Also checked the follow things:

tovari commented 3 years ago

Hi @GregoryHorvath, the new fields should be displayed on the page of the created FR as well. Currently, the page shows only the old fields only. Could you please add the new ones as well?