IFRCGo / go-frontend

MIT License
21 stars 5 forks source link

South Africa Country Cluster appears on the Africa country list #2609

Closed tovari closed 1 year ago

tovari commented 1 year ago

The South Africa Country Cluster appears on the country list on the Africa page: https://go.ifrc.org/regions/0

image

Its weird, because the setting of the cluster are the same as for other clusters, which don't show up on the list: https://goadmin.ifrc.org/en/api/country/291/change/?_changelist_filters=q%3Dsouth%2Bafrica

szabozoltan69 commented 1 year ago

There is a (local storage) saved "allCountries" file, which contains these countries. That it is the only cluster which has ISO (and ISO3) code, ZA, ZAF. It can be a data error, due to these belongs to South Africa instead:

 record_type | is_deprecated | iso | iso3 |              name               
-------------+---------------+-----+------+---------------------------------
           1 | f             | ZA  | ZAF  | South Africa
           2 | f             | ZA  | ZAF  | Southern Africa Country Cluster
szabozoltan69 commented 1 year ago

Also "GE" should be fixed: _select record_type, is_deprecated, iso, iso3,name from api_country where recordtype=2 or iso in ('GE', 'ZA') order by 1;

 record_type | is_deprecated | iso | iso3 |                          name                           
-------------+---------------+-----+------+---------------------------------------------------------
           1 | false         | ZA  | ZAF  | South Africa
           1 | false         | GE  | GEO  | Georgia
           2 | false         |     |      | Bangkok Country Cluster
           2 | false         |     |      | Beijing Country Cluster
           2 | false         |     |      | Moscow Country Cluster
           2 | false         |     |      | East Africa Country Cluster
           2 | false         |     |      | Indian Ocean Islands Country Cluster
           2 | false         |     |      | Central America Country Cluster
           2 | false         |     |      | North America and Mexico Country Cluster
           2 | false         |     |      | Central Africa Country Cluster
           2 | false         |     |      | Central and South-Eastern Europe Country Cluster
           2 | false         |     |      | South America Country Cluster
           2 | false         |     |      | Cuba, Haiti and Dominican Republic Country Cluster
           2 | false         |     |      | Dubai Country Cluster
           2 | false         |     |      | Tunis Country Cluster
           2 | true          |     |      | Eastern Africa and Indian Ocean Islands Country Cluster
           2 | false         |     |      | Sahel Country Cluster
           2 | false         |     |      | Southern Cone Country Cluster
           2 | false         |     |      | Suva Country Cluster
           2 | true          |     |      | Agrupación de Centroamérica
           2 | false         |     |      | West Coast Country Cluster
           2 | true          |     |      | Guatemala City Country Cluster
           2 | false         |     |      | Jakarta Country Cluster
           2 | false         | GE  |      | South Caucasus Country Cluster
           2 | false         |     |      | Caribbean Country Cluster
           2 | false         | ZA  | ZAF  | Southern Africa Country Cluster
           2 | false         |     |      | New Delhi Country Cluster
           2 | false         |     |      | Central Asia Country Cluster
szabozoltan69 commented 1 year ago

This bug does not appear on staging, because there the data are nice somehow. The previous query gives:

record_type|is_deprecated|iso|iso3|name                                                   |
-----------+-------------+---+----+-------------------------------------------------------+
          1|false        |ZA |ZAF |South Africa                                           |
          1|false        |GE |GEO |Georgia                                                |
          2|true         |   |    |Guatemala City Country Cluster                         |
          2|false        |   |    |Beijing Country Cluster                                |
          2|false        |   |    |Indian Ocean Islands Country Cluster                   |
          2|false        |   |    |Southern Africa Country Cluster                        |
          2|false        |   |    |Cuba, Haiti and Dominican Republic Country Cluster     |
          2|false        |   |    |Dubai Country Cluster                                  |
          2|false        |   |    |Caribbean Country Cluster                              |
          2|false        |   |    |Central America Country Cluster                        |
          2|false        |   |    |Central Asia Country Cluster                           |
          2|false        |   |    |New Delhi Country Cluster                              |
          2|false        |   |    |Suva Country Cluster                                   |
          2|false        |   |    |Central Africa Country Cluster                         |
          2|false        |   |    |Bangkok Country Cluster                                |
          2|false        |   |    |Moscow Country Cluster                                 |
          2|false        |   |    |North America and Mexico Country Cluster               |
          2|false        |   |    |Sahel Country Cluster                                  |
          2|false        |   |    |South Caucasus Country Cluster                         |
          2|false        |   |    |Southern Cone Country Cluster                          |
          2|true         |   |    |Tegucigalpa Country Cluster                            |
          2|false        |   |    |Tunis Country Cluster                                  |
          2|false        |   |    |West Africa Country Cluster                            |
          2|true         |   |    |Eastern Africa and Indian Ocean Islands Country Cluster|
          2|false        |   |    |South America Country Cluster                          |
          2|false        |   |    |Jakarta Country Cluster                                |
          2|false        |   |    |Central and South-Eastern Europe Country Cluster       |
          2|false        |   |    |East Africa Country Cluster                            |
szabozoltan69 commented 1 year ago

Before the fix on prod: select distinct iso, iso3 from api_country where record_type = 2;

iso|iso3|
---+----+
   |    |
GE |    |
ZA |ZAF |

After the data fix (update api_country set iso = null, iso3 = null where record_type = 2 and iso is not null) -

iso|iso3|
---+----+
   |    |
szabozoltan69 commented 1 year ago

After this database change and after removing Local Storage of countries from browser: kép

szabozoltan69 commented 1 year ago

Please visit https://go.ifrc.org/clear-init-cache to clear the old non-wanted cache data.

tovari commented 1 year ago

Thanks!