search

IFS-HSR / SConsolidator

An Eclipse plug-in for the build system SCons (scons.org).
24 stars 10 forks source link

Annoying pop-up when there is no SCons path set #12

Closed misto closed 10 years ago

misto commented 10 years ago

We are distributing SConsolidator as part of http://cevelop.com, and when the user starts it for the first time, he is greeted by an error message telling him that the path to SCons is not set. Is it really necessary to perform this check when the bundle is loaded, or could this be delayed until SCons needs to be actually run?

misto commented 10 years ago

AFAICS, we could simply drop the bundle listener. Do you want me to submit a pull request for that?

mrueegg commented 10 years ago

You're right, I have removed the eager pop-up and replaced it by a lazy checker when a build is triggered (see d44bd24d25b4e69cbc98a26a60825891cdb9cfbb).

misto commented 10 years ago

:+1: Thanks!

misto commented 10 years ago

Since this change, the build on our server hangs when running the tests. On Travis and my local machine it works fine though. Do you have an idea what that could be?

mrueegg commented 10 years ago

That might be because of the pop-up that comes up when the SCons path is not set and builds are run during the integration tests. I guess the tests you run are within a virtual framebuffer? This is how I run them with Travis:

before_install:
   - "export DISPLAY=:99.0"
   - "sh -e /etc/init.d/xvfb start"
script: DISPLAY=:99.0 mvn clean install
misto commented 10 years ago

That was my first thought as well, but the pop-up also appears when I run the tests locally from maven or Eclipse, and there it doesn't interfere with the tests. And yes, tests run with Xvfb too. I'll see if I can get an actual look at the virtual framebuffer.