search

IFeelBloated / vapoursynth-mvtools-sf

Single Precision MVTools
10 stars 2 forks source link

Support _aligned_malloc #17

Open ghost opened 4 years ago

ghost commented 4 years ago

Hi, I think you should consider to support _aligned_malloc as aligned_alloc is not implemented in MSVC and also not in MINGW.

_aligned_malloc is defined in malloc.h

MSYS2 consists of three subsystems and their corresponding package repositories, msys2, mingw32, and mingw64.

The mingw subsystems provide native Windows programs and are the main focus of the project. These programs are built to co-operate well with other Windows programs, independently of the other subsystems. This part builds on the MinGW-w64 project.

The msys2 subsystem provides an emulated mostly-POSIX-compliant environment for building software, package management, and shell scripting. These programs live in a virtual single-root filesystem (the root is the MSYS2 installation directory). Some effort is made to have the programs work well with native Windows programs, but it's not seamless. This part builds on the Cygwin project.

See this commit for example: https://github.com/mpv-player/mpv/commit/008faa3d7fd62c9e8af00281a04ed76db1b41391

IFeelBloated commented 4 years ago

std::aligned_alloc is defined as a standard library function in ISO C++17, I won't compromise for some homegrown variant simply because some compilers come with obsolete headers.