search

IGCIT / Intel-GPU-Community-Issue-Tracker-IGCIT

IGCIT is a Community-driven issue tracker for Intel GPUs.
GNU General Public License v3.0
114 stars 3 forks source link

SPIR-V compiler crash with yuzu ASTC decoder #159

Closed liamwhite closed 1 year ago

liamwhite commented 1 year ago

Checklist [README]

Application [Required]

yuzu

Processor / Processor Number [Required]

Core i5 12600K

Graphic Card [Required]

Arc A770 16GB

GPU Driver Version [Required]

Rendering API [Required]

Windows Build Number [Required]

Other Windows build number

No response

Intel System Support Utility report

ssu-info.txt

Description and steps to reproduce [Required]

The yuzu Nintendo Switch emulator crashes when loading any application with the Vulkan Arc driver due to a crash in SPIR-V shader compiler. The file was produced with glslangValidator and the Vulkan application has no validation errors.

Integrated graphics drivers are not affected. Mesa is not affected. Other driver families (AMD, Nvidia) are not affected.

Here is a link to the issue report: https://github.com/yuzu-emu/yuzu/issues/9072

Here is a link to the lastest version of yuzu: https://github.com/yuzu-emu/yuzu-mainline/releases

Here is a link to a zipped homebrew example game to run in the emulator which can trigger the crash: simple_triangle.zip (free software, compiled from here)

I have created a minimal application which reproduces the crash here: https://github.com/liamwhite/astc-crash/

Steps for the minimal application:

  1. mkdir build
  2. cd build
  3. cmake ..
  4. Open in VS and build main.cpp
  5. Run and it will immediately crash

arc_crash

Device / Platform

No response

Crash dumps [Required]

main.dmp.zip

Application / Windows logs

No response

liamwhite commented 1 year ago

Closing the issue then!

goldenx86 commented 1 year ago

Thank you. Now we need to implement a conversion or skip for Float64 shaders to make the game 100% playable on Intel.

goldenx86 commented 1 year ago

Link seems to be down at the moment.

Tiancxz commented 1 year ago

Thank you for your efforts. This bug has been fixed

Tiancxz commented 1 year ago

But it seems that only the issues on ARC 750 or ARC graphics card have been fixed. When I switch to XE, I will crash again

rookieplayi commented 1 year ago

what about 10th gen cpus driver ?

UziT2004 commented 1 year ago

TOTK still crashes in some locations while using Intel(R) Iris(R) Xe Graphics Will there be a fix for it anytime soon?

EstebanIntel commented 1 year ago

Hi all,

Please note that Intel cannot support issues on emulated games, since those cannot be obtained legally.

We can only work on issues with our graphics drivers if a homebrew code is provided showcasing the issue, just like in this case (thanks @liamwhite for providing the sample code).

If a similar issue to this one is still happening in other Intel graphics products, please create a new issue in this GitHub tracker providing the necessary steps to reproduce it using only legally obtained software and/or homebrew software.

goldenx86 commented 1 year ago

@UziT2004 this fixes the major crashes but there's more work to do from yuzu's part. A shader compiles invalid SPIR-V code causing crashes on gameplay, we're working on this one ATM. Tears of the Kingdom uses Float64 shaders on the intro, and Intel hardware removed support for it, so we need to implement a workaround.

Report any remaining yuzu issues to our bug tracker please: https://github.com/yuzu-emu/yuzu/issues/new/choose

rookieplayi commented 1 year ago

@goldenx86 will you also fix the crash when entering temple of time in intel gpus ? btw my intel gpu did not crash on the intro

Jonav9 commented 1 year ago

Hi all,

We have just posted driver version 31.0.101.4382, which has a possible fix for this issue. Can you all test it out?

@EstebanIntel I'm using an integrated Intel® Iris® Xᵉ graphics card, and a 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz processor. Will this update work on my laptop? I've been experiencing screen flickering when no particular software crashes, and I tried using the bug report built-in on the Intel graphics command center. But it doesn't work. Thank you.

Jonav9 commented 1 year ago

@goldenx86 will you also fix the crash when entering temple of time in intel gpus ? btw my intel gpu did not crash on the intro

I thought the fix they were talking about here was going to solve that. It crashes in the same part for me. Have you tried this update?

rookieplayi commented 1 year ago

@goldenx86 will you also fix the crash when entering temple of time in intel gpus ? btw my intel gpu did not crash on the intro

I thought the fix they were talking about here was going to solve that. It crashes in the same part for me. Have you tried this update?

my cpu is like an 8th gen so they havent update the drivers for 8th-10th gen cpus

peigongdsd commented 1 year ago

@goldenx86 will you also fix the crash when entering temple of time in intel gpus ? btw my intel gpu did not crash on the intro

I thought the fix they were talking about here was going to solve that. It crashes in the same part for me. Have you tried this update?

my cpu is like an 8th gen so they havent update the drivers for 8th-10th gen cpus

Maybe you should try Mesa on Linux.

rookieplayi commented 1 year ago

@goldenx86 will you also fix the crash when entering temple of time in intel gpus ? btw my intel gpu did not crash on the intro

I thought the fix they were talking about here was going to solve that. It crashes in the same part for me. Have you tried this update?

my cpu is like an 8th gen so they havent update the drivers for 8th-10th gen cpus

Maybe you should try Mesa on Linux.

i have a laptop bruh

rookieplayi commented 1 year ago

@goldenx86 will you also fix the crash when entering temple of time in intel gpus ? btw my intel gpu did not crash on the intro

I thought the fix they were talking about here was going to solve that. It crashes in the same part for me. Have you tried this update?

my cpu is like an 8th gen so they havent update the drivers for 8th-10th gen cpus

Maybe you should try Mesa on Linux.

linux is the same lol

FinnHello commented 1 year ago

Hope this could be solved

redbelde commented 1 year ago

so... the problem was fixed in iris xe graphics or only on Intel arc?

Kcaj5 commented 1 year ago

so... the problem was fixed in iris xe graphics or only on Intel arc?

Problem is here, Intel iris xe graphics(

EstebanIntel commented 1 year ago

Hi all,

To further clarify, this fix is for Arc only, as that is what was reported in the original post of this thread.

If a similar issue to this one is still happening in other Intel graphics products, please create a new issue in this GitHub tracker providing the necessary steps to reproduce it using only legally obtained software and/or homebrew software. Please note that Intel cannot support issues on emulated games, since those cannot be obtained legally.

@Jonav9, driver 31.0.101.4382 is integrated graphics on 11th gen Intel processors or newer plus Intel Arc. So yes, you can install this driver on a i7-1165G7 system. However, as I mentioned above, the fix is for Arc graphics only. And, if you need help with any issue other than what is described in the original post of this thread, please submit a ticket at Intel Online Service Center

IGCIT commented 1 year ago

@bulentpc issues with games running in yuzu should be opened in yuzu github page here, it has already been confirmed the issue reported in OP has been fixed, other issues/crashes should be posted in yuzu issue tracker, and if any of them is drivers related, then yuzu developers can open a new issue about it.

EstebanIntel commented 1 year ago

Hi @Whimfoome,

The original post was regarding an issue on Intel Arc. If a similar issue to this one is still happening in other Intel graphics products, please create a new issue in this GitHub tracker providing the necessary steps to reproduce it using only legally obtained software and/or homebrew software. Please note that Intel cannot support issues on emulated games, since those cannot be obtained legally.

Krusl9263 commented 1 year ago

I think this issue should be reopened because the problem is only partly fixed. It's fixed only for Arc GPU's. Iris Xe still has this problem.

Well, seems like ASTC decoder is already working on Iris Xe, and at this time Iris Xe outperforms ARC quite a lot on yuzu when playing TOTK.

nyanmisaka commented 1 year ago

The SPIR-V compiler issue only existed on Arc dGPU, it doesn't affect Xe iGPU. So it makes no sense to keep flooding this closed ticket.

https://github.com/IGCIT/Intel-GPU-Community-Issue-Tracker-IGCIT/issues/159#issuecomment-1572650451

this fixes the major crashes but there's more work to do from yuzu's part. A shader compiles invalid SPIR-V code causing crashes on gameplay, we're working on this one ATM. Tears of the Kingdom uses Float64 shaders on the intro, and Intel hardware removed support for it, so we need to implement a workaround.

Report any remaining yuzu issues to our bug tracker please: https://github.com/yuzu-emu/yuzu/issues/new/choose

The rest of the fixes should be done by the Yuzu emulator devs.

bulentpc commented 1 year ago

INTEL ARC A770 Now playable on Ryujinx emulator - thanks to the producer.

Jonav9 commented 1 year ago

@UziT2004 this fixes the major crashes but there's more work to do from yuzu's part. A shader compiles invalid SPIR-V code causing crashes on gameplay, we're working on this one ATM. Tears of the Kingdom uses Float64 shaders on the intro, and Intel hardware removed support for it, so we need to implement a workaround.

Report any remaining yuzu issues to our bug tracker please: https://github.com/yuzu-emu/yuzu/issues/new/choose

Hi @goldenx86 First, thank you for all the hard work you and the YUZU team do. I'd like to know if there's any update on this matter, referring to the intel Graphics cards, Intel Iris xe, more specifically, and TOK. Thank you!

nyanmisaka commented 1 year ago

These fixed the Vulkan device lost issue.

Jonav9 commented 1 year ago

These fixed the Vulkan device lost issue.

Thank you, that's right. I was able to pass the "temple of time door" part, that previously would crash. It crashed later after getting the recall ability from Zelda. But I'll start checking mods and seeing what works for me.

Clownacy commented 1 year ago

Please note that Intel cannot support issues on emulated games, since those cannot be obtained legally.

Is no one going to comment on this? Not everyone downloads games from shady websites: legally-owned games can be extracted using a homebrew-capable Nintendo Switch for playing in an emulator. Or is that somehow illegal too? It's pretty rude to throw the entire emulation scene under the bus by suggesting that everyone in it is obtaining games illegally.

BelleNottelling commented 1 year ago

Please note that Intel cannot support issues on emulated games, since those cannot be obtained legally.

Is no one going to comment on this? Not everyone downloads games from shady websites: legally-owned games can be extracted using a homebrew-capable Nintendo Switch for playing in an emulator. Or is that somehow illegal too? It's pretty rude to throw the entire emulation scene under the bus by suggesting that everyone in it is obtaining games illegally.

Emulation is often seen as at-best legally dubious by a lot of people. But even outside of that, Nintendo themselves are very trigger-happy with lawsuits and has many times in the past set the precedence that they do not like people reverse engineering, modifying, or emulating their games / hardware. So yeah, I get the frustration that they won't assist with issues on emulated games, but at the same time if I was Intel I would at the very least be concerned if I was going to be doing anything emulation related, most especially if it was emulation of a Nintendo product.