IGELTechnologyGmbH / supertuxkart

SuperTuxKart IGEL OS App recipe, an example how to build an IGEL OS App
Apache License 2.0
0 stars 1 forks source link

App.json with invalid properties #1

Open TobKra96 opened 6 days ago

TobKra96 commented 6 days ago

Hello, it looks like, the example does not match the new igelpkg format. If I try to build it I get the following error:

Error [Parser]: Failed to validate app.json: Additional properties are not allowed ('mountpoint', 'post_mount' were unexpected)

Failed validating 'additionalProperties' in schema['properties']['rw_partition']:
    {'additionalProperties': False,
     'description': 'Definition of the optional app partition with a '
                    'persistent filesystem',
     'properties': {'backup': {'type': 'boolean'},
                    'backup_can_drop': {'items': {'type': 'string'},
                                        'type': 'array'},
                    'backup_must_drop': {'items': {'type': 'string'},
                                         'type': 'array'},
                    'flags': {'items': {'type': 'string'}, 'type': 'array'},
                    'min_size': {'type': 'integer'},
                    'size': {'type': ['integer', 'string']}},
     'required': ['size'],
     'type': 'object'}

On instance['rw_partition']:
    {'flags': ['compressed'],
     'mountpoint': '/userhome/.config/supertuxkart',
     'post_mount': 'chown user /userhome/.config/supertuxkart',
     'size': 'small'}
Error [Parser]: Writable partition mountpoint must be /services_rw/supertuxkart, please remove it from the app.json, it is automatically filled in. You also need to adopt your package scripts/configuration to the new path.
Error [Parser]: It is not longer supported to specify a custom post_mount script. The script will be automatically generated based on the information from the dirs.json.

Is there a newer version available? After removing mountpoint and post_mount, the build process works.

igel-build-tools-static_1.37_amd64.deb igelpkg_0.9.22_amd64.deb

Best regards, TobKra

J-Bu commented 5 days ago

Hi TobKra,

thanks for the feedback we are currently in the progress of moving the recipes to the IGEL-Community account https://github.com/IGEL-Community during this process they will be reviewed and updated.

Feel free to create a MR for your fixes.

Regards, Jan