Smith crashes upon paste when clipboard is empty

IGI-111 / Smith

A simple text editor written in Rust

MIT License

169 stars 6 forks source link

Smith crashes upon paste when clipboard is empty #11

Closed matthias-t closed 6 years ago

matthias-t commented 6 years ago

How to reproduce:

reboot
edit a file with Smith
Ctrl + v

OS: Arch Linux x86_64

matthias-t commented 6 years ago

One of those unwraps should be the culprit https://github.com/IGI-111/Smith/blob/c73d653e2f0b336b945a310df36b8aedc9f99851/src/command/mod.rs#L94-L100 There's also a new version of the clipboard crate.

matthias-t commented 6 years ago

So I forked the repo and updated the dependencies, making the necessary fixes for API changes. Strangely, the handling of text selection got noticeably slower.

IGI-111 commented 6 years ago

That is quite strange, but it might have to do with updates to underlying libs like ropey more than just the clipboard handling.

I'll take a look into it.

IGI-111 commented 6 years ago

Should be fixed in the update. Do reopen if you still encounter the problem.

matthias-t commented 6 years ago

Thanks!