search

IGI-111 / Smith

A simple text editor written in Rust
MIT License
168 stars 6 forks source link

Replace macros.rs with delegate crate #14

Closed matthias-t closed 5 years ago

matthias-t commented 5 years ago

It's only necessary for libraries, and the macros module is private anyway. By the way, what does this macro do?

IGI-111 commented 5 years ago

This is fine as is, but if you want to you can broaden the scope of this PR to deleting the macro altogether.

The macro itself is a bit of a hack to implement a delegation pattern without a lot of boilerplate but there are now crates to do this like rust-delegate so it might be a good thing to just port usages to that.

matthias-t commented 5 years ago

I'm on it

matthias-t commented 5 years ago

Done!

IGI-111 commented 5 years ago

Very nice.