search

IGITUGraz / spore-nest-module

Synaptic Plasticity with Online Reinforcement learning
https://igitugraz.github.io/spore-nest-module/
GNU General Public License v2.0
25 stars 11 forks source link

Fix to Issue #17 #18

Closed kappeld closed 7 years ago

kappeld commented 7 years ago

This is a fix to issue #17. c-string arguments have been changed to Name object. This was necessary because NEST no longer allows Name objects to be build "on the fly" when multi-threading is turned on.

In the current commit, there is still a problem with the connection recorder object that needs to be adapted to work with Name object.

kappeld commented 7 years ago

I have fixed now the problem with the logger. There seems to be still a problem with the reward_in_proxy, since the test stalls. @mhoff do you have time to look at this?

kappeld commented 7 years ago

Oh, no. Actually it seems I was just impatient. I tried now to run now the example and everything seems to work now. Can you confirm and double-check everything since I made quite a lot of changes in relatively short time...

kappeld commented 7 years ago

@mhoff is it practical to make a unittest with the original example code that caused the bug? Could you prepare that?

mhoff commented 7 years ago

I can confirm that my current experiment is working just fine with this bug-fix. The version after the first commit also already showed significant learning results after a few hours, thus I can confidently say that these changes should fix the problem.

mhoff commented 7 years ago

@mhoff is it practical to make a unittest with the original example code that caused the bug? Could you prepare that?

Yes. I will take care of that. However, most likely I will not be able to do that until next week. I would be fine with merging this bug-fix branch and adding the test afterwards.