IGITUGraz / spore-nest-module

Synaptic Plasticity with Online Reinforcement learning
https://igitugraz.github.io/spore-nest-module/
GNU General Public License v2.0
25 stars 11 forks source link

Take default Python version from NEST installation #25

Open kappeld opened 6 years ago

kappeld commented 6 years ago

I would suggest to change the default behavior of the installation script to take the Python version from the nest installation. nest-config recently introduced the feature to access the python version and path, so it should be quite easy to adapt the cmake script. Since in all practical cases the python version of SPORE and NEST should be the same this is more convenient for most users. We can still allow to overwrite the default using `-Dwith-python'.

see:

nest-config  --python-executable # print full path to Python interpreter used
nest-config  --python-version     # print Python version string for interpreter
mhoff commented 6 years ago

Agreed. For the majority of users, if not for all of them, using the python version of NEST as default should be correct.

kappeld commented 6 years ago

Ok, great. I quickly tested this and implemented the following behavior:

I think this change makes the installation smoother but does not reduce the flexibility. We also have to adapt the REAMDE and wiki pages. I will make a PR later.