requirements.txt can be remove from .gitignore (if following the standard: package>=x.x.x)
cogs/ship_cog.py:
rename /ship => /ship_info ?
add a / ! warning comment above /add_cargo (because its a temporary command for development and should not be forgotten to remove)
location.py:
location could use proprety&getter
ship.py:
Can use from module import x,y,z,...
Everything else seems great and ready to be merged if those little things are changed.
Should also link resources&basic ship issue to the PR
requirements.txt can be remove from .gitignore (if following the standard: package>=x.x.x)
cogs/ship_cog.py: rename /ship => /ship_info ? add a / ! warning comment above /add_cargo (because its a temporary command for development and should not be forgotten to remove)
location.py: location could use proprety&getter
ship.py: Can use from module import x,y,z,...
Everything else seems great and ready to be merged if those little things are changed.
Should also link resources&basic ship issue to the PR