IGLADI / Ethereal-Hyperspace-Battleships

8 stars 0 forks source link

Feature create roles on join #36

Closed IGLADI closed 10 months ago

IGLADI commented 10 months ago

1 general category and 1 category per (main) guild are created with their corresponding channels when the bot joins a server. Everyone has aces to the general category while only the guild members have access to the guild specific category

Only the main channels have been created, not the feature dependent channels.

DO NOT ACCEPT until main guilds have been created (it uses guild.name) this is temp for review and I used a mock object for testing myself but it will not work without the main guilds merged before.

Fix: Main Text/voice discord channels auto created on server join Issue #6 & Create main guild roles Issue #28

LordTlasT commented 10 months ago

Currenlty reviewing this.

IGLADI commented 10 months ago

There is a lot of repeating code that could be turned into a loop.

You could use this structure for channels { {channel_type, name}, {channel_type, name}, ... } And do the same thing for the categories

Fixes

LordTlasT commented 10 months ago

Currently reviewing this.

IGLADI commented 10 months ago
  • rewrite elif to match case

Done

  • move hardcoded lists to a seperate file

Done

  • maybe it is possible to use reference to the functions in the lists like so: { create_text_channel: "announcements", create_text_channel: "off-topic", create_forum: "questions", ... }

Can be done, but don't think it's worth it for now, will come back to this when at least the MVP is done.

LordTlasT commented 10 months ago

fix your conflicts with main.