LordTlasT
commented
10 months ago - duplicate requirements
- in /help commands should be put in verbatim with backticks `/command`,
/command - rename upgrade_ship to upgrade_module
- use player.name instead of interaction or member, because later on we will have names shared across user, I will rename this in the database. Also /give_resource and /pay do not use the same name so it is confusing
- rename send_or_receive money to transaction_action or something in the likes of this.
- still need to do info for modules specificly
- https://cs50.harvard.edu/python/2022/notes/9/#map
- seperate function might be useful because you're using this logic quite often
- remove welcome_ui.py
- add docstring to 'helper' functions, at least the ones in utils.py
- the loading moves when it's edited, this could be solved by editing an empty messageg and then showing the cargo
IGLADI
TODO after trading-system PR
Description[^1]
issues: UI for command ship_info #39 Ui inventory #63 Ui energy generator #64 Ui /balance #65 Ui trading #66 Ui ship #67
Modifications[^2]
Updated toggle generator to use on/off instead of True/False. Trade modification:Deny offer if everything is 0 and moved TradeModal to the UI package. Fixed trade paginator's first page menu.
Additions[^3]
Made normal, processing, done, and error banners. All commands are updates with those banners (beside casino ofc) Completed trades UI by sending DMs & showing trade resumes.
[^1]: Description of the pull request. [^2]: Modifications, commands modified and explanation. [^3]: Files added, commands added and explanation. [^4]: Additional remarks (e. a. documentation needs to be updated)