search

IGME-Research-Studio / bloxeo-server

Server for our Brainstorm App
MIT License
2 stars 0 forks source link

Is 228/230 rework board/key val service for socket ids #235

Closed erickipnis closed 8 years ago

erickipnis commented 8 years ago

Still in progress. Need to rework the handlers next to pass the socketId along to the functions.

erickipnis commented 8 years ago

Implemented the handlers for join and leave to include socketId. Still need to make the last three functions in IS 228

erickipnis commented 8 years ago

@dropofwill I know the linter was just being annoying at the time about unused variables. It was just faster to comment it out at the time.

erickipnis commented 8 years ago

Everything is pretty much finished. Just have to prevent duplicate votes, and prevent users from readying up to vote and finish voting more than once to complete the issues.

dropofwill commented 8 years ago

Sweet :rabbit2: :rocket:

erickipnis commented 8 years ago

Finished prevention of duplicate votes and user state changes for voting. This should be ready to be merged once looked over.

dropofwill commented 8 years ago

@erickipnis This PR is fully contained in #240 correct?