IGNF / road2

NodeJS routing server aggregating several popular routing engines (video presentation (french) : https://peertube.fr/w/75fwFoW2GP8tQSGLUXUpPP)
https://ignf.github.io/road2/
GNU General Public License v3.0
11 stars 3 forks source link

[feat] GET /services implementation #43

Closed lgrd closed 1 year ago

lgrd commented 1 year ago

Create GET /services like it is specified inside https://github.com/IGNF/road2/blob/develop/documentation/apis/administration/1.0.0/api.yaml.

Code

jmkerloch commented 1 year ago

For the result of the service configuration, we can read the content of configuration file ? We don't need to get it from the service instance ?

lgrd commented 1 year ago

Yes, you can read it ;) I think you don't have to ask anything to the service.

jmkerloch commented 1 year ago

@lgrd There is a parameter withId in the API description.

Should I only check the presence of the parameter or the value must be stricly equal to 'true' or 'false' and return an error in this case ?

jmkerloch commented 1 year ago

@lgrd What should be the default value for withId ?

lgrd commented 1 year ago

Oh ! I think there is a mistake here... withId is no longer used... because you have the id in the answer. Maybe we could imagine a onlyId... but that is another feature. Can you delete this parameter inside the openapi yaml ?

jmkerloch commented 1 year ago

Ok I will change the openapi yaml.