search

IGNF / route-graph-generator

Script collection used to generate routing data for Road2 (https://github.com/IGNF/road2)
https://ignf.github.io/route-graph-generator/
GNU General Public License v3.0
7 stars 3 forks source link

Feat/check subprocess return code #76

Closed jmkerloch closed 3 months ago

jmkerloch commented 3 months ago

In this PR we check return code for all subprocess in route-graph-generator.

If the return code is different than 0 it mean that an error occured in the process.

In this case we should not continue and we raise a RuntimeError.

github-actions[bot] commented 3 months ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1057 402 38% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
r2gg/_subprocess_execution.py 9% 🟢
TOTAL 9% 🟢

updated for commit: dfdd07b by action🐍

lgrd commented 3 months ago

Hi ! Hope you're fine ^^ Could you describe the feature ? :) And can you target develop and not master ?

jmkerloch commented 3 months ago

I was waiting the checks before updating the PR :smile:

The goal is to avoid launching a step if an error occurs in a previous step.

lgrd commented 3 months ago

That's a very cool feature ! Thanks ! ;)