IGNF / route-graph-generator

Script collection used to generate routing data for Road2 (https://github.com/IGNF/road2)

https://ignf.github.io/route-graph-generator/

GNU General Public License v3.0

7 stars 3 forks source link

fix(subprocess): wait for process stop in case of None returncode #79

Closed jmkerloch closed 3 months ago

jmkerloch commented 3 months ago

subprocesse Popen.communicate function should wait for process stop.

It seems that in some cases the process is not finished because a None value was returned by valhalla_build_config command.

We need to wait for process stop before checking returncode.

github-actions[bot] commented 3 months ago

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status

1058 402 38% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status

r2gg/_subprocess_execution.py 9% 🟢

TOTAL 9% 🟢

updated for commit: 8d4935f by action🐍