search

IGS / gEAR

The gEAR Portal was created as a data archive and viewer for gene expression data including microarrays, bulk RNA-Seq, single-cell RNA-Seq and more.
https://umgear.org
GNU Affero General Public License v3.0
14 stars 4 forks source link

Update Flask to v3.0.0 #621

Closed adkinsrs closed 3 months ago

adkinsrs commented 1 year ago

Recently ran across this when doing a docker build on some code changes. Despite my Flask version being v2.1.0, pip installed Werkzeug 3.0.0, which removes some deprecated functions, and temporarily broke my local dockerized area.

Flask has also updated to v3.0.0 (documentation here -> https://flask.palletsprojects.com/en/3.0.x/changes/#version-3-0-0). I am building and running this on my local docker instance as a test of sorts, but eventually when things are calmer, it may be good to upgrade the servers to utilize tis too.

jorvis commented 11 months ago

Can you detail where all this is still used? I thought the Flask dependency went away with the removal of Vue.js

adkinsrs commented 11 months ago

Flask is still used as a dependency of the flask-restful package for the API calls. I don't think there was ever a direct Vue-Flask dependency coupling, since both are two different languages and vue was client-side.

Ricky "Shaun" Adkins Bioinformatics Software Engineer II Institute for Genome Sciences University of Maryland, School of Medicine Phone (410) 706-6766

From: Joshua Orvis @.> Sent: Saturday, December 2, 2023 1:58 AM To: IGS/gEAR @.> Cc: Adkins, Ricky (Shaun) @.>; Assign @.> Subject: Re: [IGS/gEAR] Update Flask to v3.0.0 (Issue #621)

Can you detail where all this is still used? I thought the Flask dependency went away with the removal of Vue.js

— Reply to this email directly, view it on GitHubhttps://github.com/IGS/gEAR/issues/621#issuecomment-1837064894, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLHI6SI4FRMEDUNKOQ4SWDYHLGQPAVCNFSM6AAAAAA6XWEVVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGA3DIOBZGQ. You are receiving this because you were assigned.Message ID: @.***>

jorvis commented 11 months ago

For sure. I just meant the Flask dependency was added (afaik) when Vue was added to handle the API requests. I didn't know if that was removed when the front end Vue bits were removed.

adkinsrs commented 8 months ago

Been using Flask 3.0.0 for tasks for a while now and have encountered no issues with it

adkinsrs commented 3 months ago

This is being used in v2