Staging gEAR-SVG not fitting in the result window

IGS / gEAR

The gEAR Portal was created as a data archive and viewer for gene expression data including microarrays, bulk RNA-Seq, single-cell RNA-Seq and more.

https://umgear.org

GNU Affero General Public License v3.0

13 stars 4 forks source link

Staging gEAR-SVG not fitting in the result window #822

Closed beamilon closed 3 months ago

beamilon commented 3 months ago

@adkinsrs @JPReceveur Many of the SVG do not fit in the window. Below are few examples.

adkinsrs commented 3 months ago

I can replicate this but I think it's more an issue with how the SVG was submitted to us. I worry that if I make changes to get these to fit in the tile window, the good SVGs will be messed up.

DanLesperance commented 3 months ago

It also might be the default panel layout. @beamilon can you send me the dataset collections these were found in. I'll make the arrangement so that hopefully these images show up better

beamilon commented 3 months ago

@DanLesperance Listed is where the above ones were found but there are many more:

E12.5-P30, mouse, scRNA-seq, endolymphatic sac (Griffith) in Development
The Adult Cochlea Response to PTS-Inducing Noise – Summary View (24h time point, vector graphic) in NIHL, cell type-specific transcriptomics, mouse cochlea (Hertzano 2021)
scRNA-Seq of all principal neonatal cochlear cell groups,cell type,svg (Heller) in scRNA-seq - P2 cochlea (Heller 2021)

adkinsrs commented 3 months ago

The old version of gEAR had some bad CSS styling on the SVGs that caused a few to go out of their box there (such as E16.5, P0, mouse, RNA-seq, cochlear and vestibular sensory epithelium (Avraham) ). That CSS was going to be problematic with the current version of gEAR

But I will try to come up with a CSS fix for this.

EDIT: To clarify, I don't know too much on the inner workings of SVGs, but if the SVG has a lot of whitespace in it, that would be reflected in good CSS that would make a proper SVG show fine.

adkinsrs commented 3 months ago

These will now fit in the container. However if the SVG had a lot of whitespace around the main graphic, that will also be preserved, and there's nothing much I can do for that unless edit the SVG file directly.

jorvis commented 3 months ago

We don't have that many SVGs, so if any do prove to have a lot of whitespace around them we need to trim it. I've tried to do this for any I've worked on so just let me know if you find others.